Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ip_power control for BareMetal platform #3550

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added ip_power control for BareMetal platform #3550

wants to merge 1 commit into from
+85 −2

Conversation

paulli2017
Copy link
Contributor

No description provided.

@squirrelsc
Copy link
Member

Please rebase on latest main to avoid conflict.

@squirrelsc
Copy link
Member

If you merge from main, please use rebase.

@squirrelsc
Copy link
Member

Use git rebase -i and git add/reset -p to merge commits to make each commit meaningful.

@paulli2017 paulli2017 force-pushed the paull/ippower branch 2 times, most recently from a0ba5ba to b50a704 Compare January 14, 2025 05:58
squirrelsc
squirrelsc reviewed Jan 17, 2025
View reviewed changes
lisa/sut_orchestrator/baremetal/cluster/pxe.py
self._set_ip_power(request_off)
# To make sure power-off is fully settled down, it is recommended
# to wait a short time before power-on is triggered. Local tests showed
# 1s is actually good enough to get a stable power-off status, here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request timeout is not used here, so the comment shouldn't mention it to avoid confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squirrelsc squirrelsc squirrelsc left review comments

@LiliDeng LiliDeng Awaiting requested review from LiliDeng LiliDeng is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulli2017 @squirrelsc